[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240506123624.GE10433@brightrain.aerifal.cx>
Date: Mon, 6 May 2024 08:36:24 -0400
From: Rich Felker <dalias@...c.org>
To: lixing <lixing@...ngson.cn>
Cc: musl@...ts.openwall.com
Subject: Re: Add PAGESIZE definition for LoongArch
On Mon, May 06, 2024 at 05:05:36PM +0800, lixing wrote:
> Hi, Rich,
>
> arch/loongarch64/bits/limits.h | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 arch/loongarch64/bits/limits.h
>
> diff --git a/arch/loongarch64/bits/limits.h b/arch/loongarch64/bits/limits.h
> new file mode 100644
> index 00000000..5cd9aad6
> --- /dev/null
> +++ b/arch/loongarch64/bits/limits.h
> @@ -0,0 +1 @@
> +#define PAGESIZE 16384
Can you explain why you want this change? I would be very hesitant to
merge it. Defining PAGESIZE for an arch is a contract that the
application-facing runtime page size (i.e. mmap granularity) can
*never*, now or in the future, be anything other than the value you
define this macro as having.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
