|
Message-ID: <20240427164050.GA10433@brightrain.aerifal.cx> Date: Sat, 27 Apr 2024 12:40:50 -0400 From: Rich Felker <dalias@...c.org> To: lolzery wowzery <wowzeryest@...il.com> Cc: musl@...ts.openwall.com, Duncan Bellamy <dunk@...kimushi.com>, info@...ordhuis.nl, tony.ambardar@...il.co Subject: Re: [PATCH 1/2] V3 resubmitting old statx patch with changes On Wed, Apr 24, 2024 at 07:55:32PM -0400, lolzery wowzery wrote: > Hi all! I'm new to git over email, new to musl, and I want to really > get into contributing to musl. So, I'd really appreciate any > tips/comments/info for a newbie like me! > > Please do not merge these changes yet. There's numerous problems with > this code above and beyond the issues you pointed out, and each of > those issues led me down successive rabbit holes all over the musl > source code and I've ended up opening a sizable can of worms, > including io race condition bugs in fallback conditions, symbol > weakness problems, header/struct misorganization, and bugs in syscall > support detection making musl silently/unexpectedly fail under certain > seccomp configurations. > > Also, let me cite the earlier patch from tony.ambardar@...il.com about > renameat2. My patch will include a full proper renameat2 > implementation with validation and fallback and will compile on > systems where SYS_renameat2 is undefined (using exclusively the > fallback.) > > I recognize I probably sound like an over-eager-beaver fussing over > fools-gold as I'm new and none of you know me. (That's the assumption > I myself would make if a new guy showed up claiming to have lots of > bug fixes and stuff.) So, please suspend your disbelief for a short > while until I can give my full report and all fixes tomorrow for > everyone to review. Give me a chance to prove my commitment to musl > and watch as I uphold my pledge to maintain my areas of the code in > musl and keep them ship-shape. > > Have a great day everyone and really looking forwards to sharing my > full report tomorrow!, Ping. Any updates?
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.