musl - Re: Re: [PATCH] Increase NGROUPS

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CWXP265MB136807F35F02410511FA95A5BC072@CWXP265MB1368.GBRP265.PROD.OUTLOOK.COM>
Date: Tue, 9 Apr 2024 12:54:04 +0000
From: Kate Deplaix <kit-ty-kate@...look.com>
To: Rich Felker <dalias@...c.org>
CC: "musl@...ts.openwall.com" <musl@...ts.openwall.com>
Subject: Re: Re: [PATCH] Increase NGROUPS_MAX from 32 to 1024

Hi,

Are there any updates on this by any chance?

Many thanks,
Kate
________________________________
From: Rich Felker <dalias@...c.org>
Sent: 12 March 2024 00:46
To: Kate Deplaix <kit-ty-kate@...look.com>
Cc: musl@...ts.openwall.com <musl@...ts.openwall.com>
Subject: Re: [musl] Re: [PATCH] Increase NGROUPS_MAX from 32 to 1024

On Mon, Mar 11, 2024 at 06:31:13PM +0000, Kate Deplaix wrote:
> Hi,
>
> Any chance this patch could be looked at?

Thanks for the ping. I'll take a look and see if we can open a
discussion on either doing something like this, or a more complete
fix, in this release cycle.

Rich

> ________________________________
> From: Kate Deplaix
> Sent: 14 November 2023 23:35
> To: musl@...ts.openwall.com <musl@...ts.openwall.com>
> Subject: [PATCH] Increase NGROUPS_MAX from 32 to 1024
>
> Such a restrictive value for NGROUPS_MAX makes it impossible to have a musl-based system with a user belonging to more than 32 groups. If done on the root user, this will break your system.
> It also makes it impossible to use certain functions in binaries that have been compiled with musl.
>
> This new value is still very far from Linux's NGROUPS_MAX of 65536 that has been there since Linux 2.6.4 but this is at least one tiny step in the right direction while maintainers investigate how to match Linux's value.
>
> ref: https://www.openwall.com/lists/musl/2021/07/03/1
> ref: https://www.openwall.com/lists/musl/2022/12/06/3
> ref: https://github.com/ocaml/opam/pull/5383
> ---
>  include/limits.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/limits.h b/include/limits.h
> index 53a27b9d..501c3612 100644
> --- a/include/limits.h
> +++ b/include/limits.h
> @@ -45,7 +45,7 @@
>  #define NAME_MAX 255
>  #endif
>  #define PATH_MAX 4096
> -#define NGROUPS_MAX 32
> +#define NGROUPS_MAX 1024
>  #define ARG_MAX 131072
>  #define IOV_MAX 1024
>  #define SYMLOOP_MAX 40
> --
> 2.40.1

Content of type "text/html" skipped

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.