Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <ZR29J211K8CTWWbm@fifth.space>
Date: Wed, 4 Oct 2023 21:29:43 +0200
From: Quentin Rameau <quinq@...th.space>
To: musl@...ts.openwall.com
Subject: [PATCH] Remove arbitrary limit from NS resolution

The name resolution would abort when getting more than 63 records per
request, due to what seems to be a left-over from the original code.

Somehow reported by Daniel Stefanik[0].

[0] https://gitlab.alpinelinux.org/alpine/aports/-/issues/15320
---
 src/network/dns_parse.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/network/dns_parse.c b/src/network/dns_parse.c
index ea1ec126..09813112 100644
--- a/src/network/dns_parse.c
+++ b/src/network/dns_parse.c
@@ -12,7 +12,6 @@ int __dns_parse(const unsigned char *r, int rlen, int (*callback)(void *, int, c
 	p = r+12;
 	qdcount = r[4]*256 + r[5];
 	ancount = r[6]*256 + r[7];
-	if (qdcount+ancount > 64) return -1;
 	while (qdcount--) {
 		while (p-r < rlen && *p-1U < 127) p++;
 		if (p>r+rlen-6)
-- 
2.42.0

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.