musl - Re: Re: On the redefinition of stdin, stdout, etc. in stdio. h

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <266b8af9.3c84.189192eb083.Coremail.zhixing@nj.iscas.ac.cn>
Date: Mon, 3 Jul 2023 08:37:17 +0800 (GMT+08:00)
From: 程智星 <zhixing@...iscas.ac.cn>
To: musl@...ts.openwall.com
Subject: Re: Re: On the redefinition of stdin, stdout, etc. in stdio. h

hi,friend:

I have a question to ask:

1. The stdin and stdout are redefined in the stdio. h file in the Musl source code, as follows:

extern FILE *const stdin;
extern FILE *const stdout;
extern FILE *const stderr;

#define stdin  (stdin)
#define stdout (stdout)
#define stderr (stderr)
but,In glibc, they are only redefined as themselves, as follows:

/* Standard streams.  */
extern FILE *stdin;             /* Standard input stream.  */
extern FILE *stdout;            /* Standard output stream.  */
extern FILE *stderr;            /* Standard error output stream.  */
/* C89/C99 say they're macros.  Make them happy.  */
#define stdin stdin
#define stdout stdout
#define stderr stderr
Based on what considerations we will make this change? 

2. Based on the above modifications, I will report the following errors when compiling packages such as lcr and lxc using Musl as the basic library for yocto embedded compilation:
 -o json/.libs/liblxc_la-json_common.o
| In file included from ../../../lxc-4.0.3/src/lxc/json/read-file.h:5,
|                  from ../../../lxc-4.0.3/src/lxc/json/defs.c:6:
| ../../../lxc-4.0.3/src/lxc/json/defs.c: In function 'make_defs_hook':
| ../../../lxc-4.0.3/src/lxc/json/defs.c:86:26: error: expected identifier before '(' token
|    86 |                 if (ctx-&gt;stderr &gt; 0)
|       |                          ^~~~~~
| ../../../lxc-4.0.3/src/lxc/json/defs.c:87:34: error: expected identifier before '(' token
|    87 |                     fprintf(ctx-&gt;stderr, "WARNING: unknown key found: %s\n", tree-&gt;u.object.keys[i]);
|       |                                  ^~~~~~
| ../../../lxc-4.0.3/src/lxc/json/defs.c:87:21: error: too few arguments to function 'fprintf'
|    87 |                     fprintf(ctx-&gt;stderr, "WARNING: unknown key found: %s\n", tree-&gt;u.object.keys[i]);
|       |                     ^~~~~~~
| In file included from ../../../lxc-4.0.3/src/lxc/json/read-file.h:5,
|                  from ../../../lxc-4.0.3/src/lxc/json/defs.c:6:

Is there a solution to this error report; I tried to synchronize their definitions in the Musl source code with those in Glibc, and there was no problem compiling images. Can it be modified to be consistent with glibc?

Looking forward to your reply！

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.