[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CA+X7ob_BeAOWb_sb_7C9s+ap7fi3oYYG86qNMsaD8Urdim2ovA@mail.gmail.com>
Date: Tue, 11 Apr 2023 22:38:57 +0800
From: Matthias Görgens <matthias.goergens@...il.com>
To: musl@...ts.openwall.com
Subject: Re: [PATCH v3] Fix UB in getmntent_r on extremely long lines
On Tue, 11 Apr 2023, 22:32 Rich Felker, <dalias@...c.org> wrote:
> Can you do this as a one-line change to restart the loop like I
> suggested? I know the resulting code arguably isn't as pretty to folks
> with an allergy to gotos, but the more important aspect is that the
> change history is clear and obvious to anyone who wants to read it, to
> see that no change except the one described is being made by the
> patch.
>
Thanks for the quick response on the channel!
Sure, I can use the goto, if you prefer that.
Btw, I agree that the diff with the loop looks a bit big in the email. But
when you look at it with `git show --ignore-all-space` it's about the same
size of diff as the goto. (And that's how I typically review history of a
repository.)
>
Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
