Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230405115445.GG3298@brightrain.aerifal.cx>
Date: Wed, 5 Apr 2023 07:54:46 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Cc: Florian Weimer <fweimer@...hat.com>
Subject: Re: [PATCH v9 0/13] implement dlmem() function (fwd)

Well this is disturbing. We probably need to fix gcc here (and a lot
of code in the wild may be broken) because musl has no such locking
where it doesn't belong.

Return-Path: <fweimer@...hat.com>
Received: from us-smtp-delivery-124.mimecast.com ([::ffff:170.10.129.124])
	by brightrain.aerifal.cx with ESMTP
	for dalias@...c.org; 05 Apr 2023 09:31:59 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1680687118;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fb6x7zT+IQGUZx6mqvTtXg0PWLJ56E9UXHGg+pBvloQ=;
	b=Ssf78B/pTS0UHjnDTctE212n3j3Jx0bJAemchA0sE2001plwsVsQThEmU9MDa/yz4g66/e
	oZ2w2dyyfgL9OAjSZTRY3LWdDnR8aWqMn4JOfvDIL5hNnTAqQfg09slY+1hJ3bQgo92/jC
	PYA/1zVuiaGmGQ9d6wRnYBroeq//kt4=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-201-dTMVpbyOMPCVmn9TCLegoA-1; Wed, 05 Apr 2023 05:31:57 -0400
X-MC-Unique: dTMVpbyOMPCVmn9TCLegoA-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9BE2D3C0D863;
	Wed,  5 Apr 2023 09:31:56 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.192.210])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id EEEA8140EBF4;
	Wed,  5 Apr 2023 09:31:54 +0000 (UTC)
From: Florian Weimer <fweimer@...hat.com>
To: Szabolcs Nagy via Libc-alpha <libc-alpha@...rceware.org>
Cc: stsp <stsp2@...dex.ru>,  Adhemerval Zanella Netto
 <adhemerval.zanella@...aro.org>,  janderson@...e.edu,  Carlos O'Donell
 <carlos@...hat.com>,  Rich Felker <dalias@...c.org>,  Szabolcs Nagy
 <szabolcs.nagy@....com>
Subject: Re: [PATCH v9 0/13] implement dlmem() function
References: <a08c9579-e25a-298c-6cd2-d355d32fa7e7@...aro.org>
	<e19ed6a5-67c4-f6c4-9392-b162ffb41209@...dex.ru>
	<ZCbP+K63XLFDxYYE@....com>
	<2f3a10fa-4f79-7f9a-6407-d227dbf31935@...dex.ru>
	<ZCcUleo68cmjAHoI@....com>
	<f0d8f6c1-2b73-550e-4bcf-ebdf84b3b9b2@...dex.ru>
	<ZCqktritFnXN8Rgv@....com>
	<298b04a6-3055-b89b-59c1-4cfbe955848e@...dex.ru>
	<ZCrAFxOrADRz2Wej@....com>
	<81749d04-8cdb-de0b-b88e-24347ed535ba@...dex.ru>
	<ZC02kzMyqzy30XoU@....com>
Date: Wed, 05 Apr 2023 11:31:53 +0200
In-Reply-To: <ZC02kzMyqzy30XoU@....com> (Szabolcs Nagy via Libc-alpha's
	message of "Wed, 5 Apr 2023 09:51:31 +0100")
Message-ID: <87fs9en08m.fsf@...enburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

* Szabolcs Nagy via Libc-alpha:

> The 04/05/2023 12:29, stsp wrote:
>> - dl_iterate_phdr() seems to be calling the user
>> =C2=A0 callback under dl_load_write_lock lock.
>
> this is a known bug.

It's also not something we can fix because the libgcc unwinder has code
on it that relies on this implicit loader lock to protect its internal
data structures.  The libgcc unwinder can be statically linked, so we
can't remove the locking without adding a new symbol version.

I suspect other uses of dl_iterate_phdr are similar.

Thanks,
Florian

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.