[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AF96C6E1-E750-4E1A-BE5B-0987460C6296@trust-in-soft.com>
Date: Thu, 30 Mar 2023 09:29:12 +0000
From: Pascal Cuoq <cuoq@...st-in-soft.com>
To: "musl@...ts.openwall.com" <musl@...ts.openwall.com>
CC: Matthias Goergens <matthias.goergens@...il.com>
Subject: Re: [PATCH] mntent: deal with escaped whitespace in mtab and
fstab
>> sorry missed the < 0.
>
> I made that exact same error when first reading the code. I wonder whether we
> should put the zero in front, to make it clearer to readers? Like `0 >
> fprintf(...`
As someone who reviews tons of C code from different authors and application domains, I expect the result of fprintf to be assigned to a variable and that variable to be used in the return statement. Anything else will give me pause or be confused for something that works when it doesn't.
Pascal
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
