Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAE2XoE9esb+23NfWGBnyNy1khdMrWJgTZkv976W8qrupMOFFEQ@mail.gmail.com>
Date: Wed, 23 Nov 2022 12:31:27 +0800
From: 罗勇刚(Yonggang Luo) <luoyonggang@...il.com>
To: musl@...ts.openwall.com
Cc: Reini Urban <reini.urban@...il.com>
Subject: Re: C23 implications for C libraries

I have concern about the macros guard with __cplusplus and __STDC_VERSION__

#if (__cplusplus >= 201103L) || (__STDC_VERSION__ >= 202311L)
#define NULL nullptr
#elif defined(__cplusplus)
#define NULL 0L              /* Any of 0, 0L, 0LL as wide as a void* */
#else
#define NULL ((void*)0)
#endif


I think all of these should be guarded with
#if (defined(__cplusplus) && (__cplusplus >= 201103L)) ||
(defined(__STDC_VERSION__) && (__STDC_VERSION__ >= 202311L))

this is safer to avoid -Wundef complain it

On Tue, Nov 22, 2022 at 5:11 AM Jₑₙₛ Gustedt <jens.gustedt@...ia.fr> wrote:
>
> Reini,
>
> on Mon, 21 Nov 2022 12:46:37 +0100 you (Reini Urban
> <reini.urban@...il.com>) wrote:
>
> > The last line has a typo:
> >
> > https://icube-forge.unistra.fr/icps/c23-library/-/blob/main/README.md
> >
> > besearch_s => bsearch_s
>
> thanks! if that were the only thing that is still missing …
>
> BTW, there is now a html page that is easier to access and to bookmark
>
> https://gustedt.gitlabpages.inria.fr/c23-library/
>
> Thanks
> Jₑₙₛ
>
> --
> :: INRIA Nancy Grand Est ::: Camus ::::::: ICube/ICPS :::
> :: :::::::::::::::::::::: gsm France : +33 651400183   ::
> :: ::::::::::::::: gsm international : +49 15737185122 ::
> :: http://icube-icps.unistra.fr/index.php/Jens_Gustedt ::



--
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo

Content of type "text/html" skipped

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.