[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20221022135723.31813-1-ismael@iodev.co.uk>
Date: Sat, 22 Oct 2022 15:57:23 +0200
From: Ismael Luceno <ismael@...ev.co.uk>
To: musl@...ts.openwall.com
Cc: Rich Felker <dalias@...c.org>,
Ismael Luceno <ismael@...ev.co.uk>
Subject: [PATCH] remove strdupa
There's no portable way to implement strdupa without double evaluation
of it's parameter, and it's use leads to vulnerabilities, since there's
no chance to check for stack overruns.
Signed-off-by: Ismael Luceno <ismael@...ev.co.uk>
---
include/string.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/string.h b/include/string.h
index 43ad0942edd5..65fe0d503004 100644
--- a/include/string.h
+++ b/include/string.h
@@ -88,7 +88,6 @@ void explicit_bzero (void *, size_t);
#endif
#ifdef _GNU_SOURCE
-#define strdupa(x) strcpy(alloca(strlen(x)+1),x)
int strverscmp (const char *, const char *);
char *strchrnul(const char *, int);
char *strcasestr(const char *, const char *);
--
2.38.1
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
