[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220906184826.GA1649@voyager>
Date: Tue, 6 Sep 2022 20:48:26 +0200
From: Markus Wichmann <nullplan@....net>
To: musl@...ts.openwall.com
Cc: Gabriel Ravier <gabravier@...il.com>,
Joakim Sindholt <opensource@...sha.com>
Subject: Re: ecvt(0, 0, ...) is broken
On Tue, Sep 06, 2022 at 10:17:36AM -0400, Rich Felker wrote:
> But these are garbage functions. The
> right answer is to fix whatever is using them to use snprintf and move
> on.
>
> Rich
>
>
Well, then why not remove them from the lib? Any program using them
would invoke a link failure. Indeed, for GCC, the declarations could be
retained and an error attribute be added. Configure tests would fail to
find these functions and possibly switch on alternative paths.
Of course, that is not ABI compatible. But isn't excising broken
functions better than retaining them? Because as the OP showed, our
implementations are not behaving as some callers would expect.
Ciao,
Markus
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
