[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220824184704.GA1923@voyager>
Date: Wed, 24 Aug 2022 20:47:04 +0200
From: Markus Wichmann <nullplan@....net>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] epoll: return EINVAL from epoll_create() if size
is non-positive
On Wed, Aug 24, 2022 at 03:26:52PM +0100, Kristina Martsenko wrote:
> The man page for epoll_create() states that the 'size' argument must be
> positive, otherwise EINVAL is returned. musl currently ignores the
> argument and does not return EINVAL. Change it to match the man page.
>
> Worth noting that this is needed for an LTP (Linux Test Project) test to
> pass (epoll_create02).
I am wondering if this change is sensible. On musl, the size argument is
never handed to the kernel. Failing for nonpositive arguments may be in
the spec, but it might make users assume the argument is actually used.
But it isn't. epoll_create() always calls epoll_create1(), and that
function falls back to the epoll_create syscall with a constant argument
of 1 if epoll_create1 is not available.
Ciao,
Markus
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
