musl - Re: RE: [PATCH] fix: Use $srcdir in configure test for add-cfi script

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220107183202.GL7074@brightrain.aerifal.cx>
Date: Fri, 7 Jan 2022 13:32:02 -0500
From: Rich Felker <dalias@...c.org>
To: Wesley Wiser <wesleywiser@...rosoft.com>
Cc: "musl@...ts.openwall.com" <musl@...ts.openwall.com>
Subject: Re: RE: [PATCH] fix: Use $srcdir in configure test for
 add-cfi script

On Fri, Jan 07, 2022 at 06:02:57PM +0000, Wesley Wiser wrote:
> On Thu, Oct 21, 2021 at 04:09:30PM -0400, Wesley Wiser wrote:
> > I noticed while building musl with musl-cross-make[1] that adding --enable-debug to the MUSL_CONFIG variable did not enable CFI directives even though I was compiling for a supported platform (x86_64):
> > I believe the issue is that configure tests for "tools/add-cfi.$ARCH.awk" instead of "$srcdir/tools/add-cfi.$ARCH.awk". Changing configure as described resolves this and I've confirmed the debugging information is present in resulting binary.
> > Below is a patch for this change. 
> 
> Hello all,
> 
> Just wanted to follow up and see if there was any feedback on this
> patch. I can confirm it does resolve the described issue.

Thanks for the ping. It looks good; I'll merge it now.

Rich

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.