musl - [PATCH v2] A small type change in __init

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <39354A43-2B16-4E29-930F-E17EA93EAB6B@arm.com>
Date: Tue, 25 May 2021 15:46:40 +0000
From: Joe Ramsay <Joe.Ramsay@....com>
To: "musl@...ts.openwall.com" <musl@...ts.openwall.com>
Subject: [PATCH v2] A small type change in __init_tls

Hi all,

Thanks for the previous review, and for explaining where I'd made some
wrong assumptions. I've pared the original patch down a bit.

This patch changes a size_t in static_init_tls to a uintptr_t, which
is a more appropriate type as the variable in question may contain a
pointer. Tested against libc-test with gcc 7 on x86 and clang 9 on
AArch64, with no new failures.

Thanks,
Joe
---
 src/env/__init_tls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/env/__init_tls.c b/src/env/__init_tls.c
index a93141ed..1d3d5eda 100644
--- a/src/env/__init_tls.c
+++ b/src/env/__init_tls.c
@@ -84,7 +84,7 @@ static void static_init_tls(size_t *aux)
        unsigned char *p;
        size_t n;
        Phdr *phdr, *tls_phdr=0;
-       size_t base = 0;
+       uintptr_t base = 0;
        void *mem;

        for (p=(void *)aux[AT_PHDR],n=aux[AT_PHNUM]; n; n--,p+=aux[AT_PHENT]) {
--
2.24.3 (Apple Git-128)

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.