musl - Re: Linux powerpc new system call instruction and ABI

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87im3727or.fsf@linux.ibm.com>
Date: Mon, 24 May 2021 17:33:24 -0300
From: Matheus Castanho <msc@...ux.ibm.com>
To: Matheus Castanho <msc@...ux.ibm.com>
Cc: "Dmitry V. Levin" <ldv@...linux.org>, Florian Weimer
 <fweimer@...hat.com>,
        Matheus Castanho via Libc-alpha
 <libc-alpha@...rceware.org>,
        linux-api@...r.kernel.org, musl@...ts.openwall.com,
        Nicholas Piggin <npiggin@...il.com>, libc-dev@...ts.llvm.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: Linux powerpc new system call instruction and ABI


Matheus Castanho <msc@...ux.ibm.com> writes:

> Dmitry V. Levin <ldv@...linux.org> writes:
>
>> On Fri, May 21, 2021 at 05:00:36PM -0300, Matheus Castanho wrote:
>>> Florian Weimer <fweimer@...hat.com> writes:
>>> > * Matheus Castanho via Libc-alpha:
>>> >> From: Nicholas Piggin <npiggin@...il.com>
>>> >> Subject: [PATCH 1/1] powerpc: Fix handling of scv return error codes
>>> >>
>>> >> When using scv on templated ASM syscalls, current code interprets any
>>> >> negative return value as error, but the only valid error codes are in
>>> >> the range -4095..-1 according to the ABI.
>>> >>
>>> >> Reviewed-by: Matheus Castanho <msc@...ux.ibm.com>
>>> >
>>> > Please reference bug 27892 in the commit message.  I'd also appreciate a
>>> > backport to the 2.33 release branch (where you need to add NEWS manually
>>> > to add the bug reference).
>>>
>>> No problem. [BZ #27892] appended to the commit title. I'll make sure to
>>> backport to 2.33 as well.
>>
>> Could you also mention in the commit message that the change fixes
>> 'signal.gen.test' strace test where it was observed initially?
>
> Sure, no problem. I'll commit it later today.

Since the patch falls into the less-than-15-LOC category and this is
Nick's first contribution to glibc, looks like he doesn't need a
copyright assignment.

Pushed to master as 7de36744ee1325f35d3fe0ca079dd33c40b12267

Backported to 2.33 via commit 0ef0e6de7fdfa18328b09ba2afb4f0112d4bdab4

Thanks,
Matheus Castanho

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.