[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAEg67GnY3dAenC2Y+4EYhqe_G1k9ksnH4107TPgFN0XyUKFjBw@mail.gmail.com>
Date: Thu, 14 Jan 2021 21:24:37 +1100
From: Patrick Oppenlander <patrick.oppenlander@...il.com>
To: Patrick Oppenlander <patrick.oppenlander@...il.com>, musl@...ts.openwall.com
Subject: Re: [PATCH] install symlink to liblto_plugin.so into lib/bfd-plugins
On Thu, Jan 14, 2021 at 7:09 PM Szabolcs Nagy <nsz@...t70.net> wrote:
>
> * patrick.oppenlander@...il.com <patrick.oppenlander@...il.com> [2021-01-14 15:03:42 +1100]:
> > From: Patrick Oppenlander <patrick.oppenlander@...il.com>
> >
> > The ar, nm and ranlib tools will automatically load plugins from the
> > lib/bfd-plugins directory if present.
> >
> > With this symlink in place it is no longer necessary to use the gcc-
> > prefixed versions of these tools (or the --plugin argument) to handle
> > LTO objects.
> > ---
> > litecross/Makefile | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/litecross/Makefile b/litecross/Makefile
> > index 8ec0ed2..8bae518 100644
> > --- a/litecross/Makefile
> > +++ b/litecross/Makefile
> > @@ -254,6 +254,8 @@ install-binutils: | obj_binutils/.lc_built
> > install-gcc: | obj_gcc/.lc_built
> > cd obj_gcc && $(MAKE) MAKE="$(MAKE) $(LIBTOOL_ARG)" DESTDIR=$(DESTDIR)$(OUTPUT) install
> > ln -sf $(TARGET)-gcc $(DESTDIR)$(OUTPUT)/bin/$(TARGET)-cc
> > + mkdir -p $(DESTDIR)$(OUTPUT)/lib/bfd-plugins
> > + ln -sf ../../libexec/gcc/$(TARGET)/$(file < src_gcc/gcc/BASE-VER)/liblto_plugin.so $(DESTDIR)$(OUTPUT)/lib/bfd-plugins
>
> file < BASE-VER
>
> does not do anything useful for me, did you mean
>
> cat BASE-VER
>
> ?
It's this:
https://www.gnu.org/software/make/manual/html_node/File-Function.html
I think it was added in GNU make 4.0 around 2013.
> this does not work if different TARGETs are installed to the same OUTPUT
>
> or is the plugin independent from target?
> then maybe a copy would be better than a symlink
I believe the plugin is target independent but will change between gcc versions.
The plugin is only ~100k so a file copy should be fine. I can submit a
new patch tomorrow when I'm back on the dev box.
Patrick
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
