|
Message-Id: <F4C8EA33-9721-47A5-BEC6-5A29A7072989@shiz.me> Date: Mon, 28 Dec 2020 18:01:45 +0100 From: Shiz <hi@...z.me> To: musl@...ts.openwall.com Cc: darkkirb@...kkirb.be Subject: Re: [PATCH] Add support for LLVM's Control Flow Integrity (V2) Hi, It seems to me guarding all of those with #ifdef __clang__ is not the optimal approach. What if another compilers decides to pick up the spec, or an older non-CFI Clang is used to compile? I think it's more logical to check the no_sanitize attribute with a functional test (like __has_attribute), and to just apply the used attribute unconditionally. - Shiz
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.