Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20201107065143.10191-2-ericonr@disroot.org>
Date: Sat,  7 Nov 2020 03:51:43 -0300
From: Érico Nogueira <ericonr@...root.org>
To: musl@...ts.openwall.com
Cc: Érico Rolim <erico.erc@...il.com>
Subject: [PATCH 2/2] sbsiglist: fix typo when checking cli args.

From: Érico Rolim <erico.erc@...il.com>

type_str was being checked twice, and owner_guid_str wasn't checked at
all. This lead to a possible segfault when only --owner was missing from
the command line arguments.
---
 src/sbsiglist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sbsiglist.c b/src/sbsiglist.c
index 7d396fa..aada63a 100644
--- a/src/sbsiglist.c
+++ b/src/sbsiglist.c
@@ -241,7 +241,7 @@ int main(int argc, char **argv)
 		return EXIT_FAILURE;
 	}
 
-	if (!type_str) {
+	if (!owner_guid_str) {
 		fprintf(stderr, "No owner specified\n");
 		usage();
 		return EXIT_FAILURE;
-- 
2.29.2

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.