|
Message-ID: <20200625173339.GQ6430@brightrain.aerifal.cx> Date: Thu, 25 Jun 2020 13:33:40 -0400 From: Rich Felker <dalias@...c.org> To: musl@...ts.openwall.com Subject: Re: [PATCH] Fix signed compare warning On Thu, Jun 25, 2020 at 08:58:41AM -0700, Khem Raj wrote: > > > On 6/24/20 4:20 PM, Daniel Santos wrote: > > Signed-off-by: Daniel Santos <daniel.santos@...ox.com> > > --- > > src/thread/__timedwait.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/thread/__timedwait.c b/src/thread/__timedwait.c > > index 666093be..9829b93e 100644 > > --- a/src/thread/__timedwait.c > > +++ b/src/thread/__timedwait.c > > @@ -38,7 +38,7 @@ int __timedwait_cp(volatile int *addr, int val, > > if (priv) priv = FUTEX_PRIVATE; > > > > if (at) { > > - if (at->tv_nsec >= 1000000000UL) return EINVAL; > > + if ((unsigned long)at->tv_nsec >= 1000000000UL) return EINVAL; > > if (__clock_gettime(clk, &to)) return EINVAL; > > to.tv_sec = at->tv_sec - to.tv_sec; > > if ((to.tv_nsec = at->tv_nsec - to.tv_nsec) < 0) { > > > may be use < 0 || >= 1000000000L and avoid the cast. > there is a similar issue in src/thread/pthread_cond_timedwait.c as well This is not a bug but intentional usage of the language.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.