Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200309183216.31559-1-amonakov@ispras.ru>
Date: Mon,  9 Mar 2020 21:32:16 +0300
From: Alexander Monakov <amonakov@...ras.ru>
To: musl@...ts.openwall.com
Subject: [PATCH] remove redundant condition in memccpy


Commit d9bdfd164 ("fix memccpy to not access buffer past given size")
correctly added a check for 'n' nonzero, but made the pre-existing test
'*s==c' redundant: n!=0 implies *s==c. Remove the unnecessary check.

Reported by Alexey Izbyshev.
---

Let me also point out that the aforementioned change did not appear
on this mailing list.

Alexander

 src/string/memccpy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


View attachment "0321-remove-redundant-condition-in-memccpy.patch" of type "text/x-patch" (363 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.