[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200129154925.GI30412@brightrain.aerifal.cx>
Date: Wed, 29 Jan 2020 10:49:25 -0500
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: MUSL not including <sys/ttydefaults.h> in <sys/ioctl.h>
On Wed, Jan 29, 2020 at 01:50:12PM +0100, Petr Vorel wrote:
> Hi,
>
> Glibc is including <sys/ttydefaults.h> in <sys/ioctl.h> with following comment:
>
> /* On a Unix system, the system <sys/ioctl.h> probably defines some of
> the symbols we define in <sys/ttydefaults.h> (usually with the same
> values). The code to generate <bits/ioctls.h> has omitted these
> symbols to avoid the conflict, but a Unix program expects <sys/ioctl.h>
> to define them, so we must include <sys/ttydefaults.h> here. */
>
> I guess glibc is (as usual) wrong and therefore users who needs these
> definitions should load also <sys/ttydefaults.h> explicitly.
ioctl.h isn't governed by any current standard, so we could include
sys/ttydefaults.h here, but I don't think it makes sense to. These
macros logically have nothing to do with the ioctl interface; rather
they go with termios. Programs that want them should probably be
including the header explicitly, or better yet not using them at all.
I also found a couple small issues in that header I'm fixing now.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
