Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <eb6e9ee55907488492048b07884f29a9@huawei.com>
Date: Fri, 18 Oct 2019 12:35:45 +0000
From: "wangjianjian (C)" <wangjianjian3@...wei.com>
To: "musl@...ts.openwall.com" <musl@...ts.openwall.com>
CC: "wangjianjian (C)" <wangjianjian3@...wei.com>
Subject: [PATCH 1/1] ungetc: Cast to unsigned char before push back to stream

>From 4d24e6fee85ed878dc632dd29aabeb7c7454952e Mon Sep 17 00:00:00 2001
From: Wang Jianjian <wangjianjian3@...wei.com>
Date: Fri, 18 Oct 2019 20:28:29 +0800
Subject: [PATCH 1/1] ungetc: Cast to unsigned char before push back to stream

Per Posix standard, casting to unsigned char is need before returning C
and pushing C back to stream.

Signed-off-by: Wang Jianjian <wangjianjian3@...wei.com>
---
 src/stdio/ungetc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/stdio/ungetc.c b/src/stdio/ungetc.c
index 180673a4..9733091a 100644
--- a/src/stdio/ungetc.c
+++ b/src/stdio/ungetc.c
@@ -12,9 +12,9 @@ int ungetc(int c, FILE *f)
                return EOF;
        }

-       *--f->rpos = c;
+       *--f->rpos = (unsigned char)c;
        f->flags &= ~F_EOF;

        FUNLOCK(f);
-       return c;
+       return (unsigned char)c;
 }
--
2.17.1

BR,
Wang Jianjian

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.