[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190730161336.GA1506@brightrain.aerifal.cx>
Date: Tue, 30 Jul 2019 12:13:36 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: Re: [PATCH] In glob(), do not require that the target of
a symlink exists.
On Tue, Jul 30, 2019 at 12:04:57PM -0400, James Y Knight wrote:
> Ping -- is this patch ok?
I think the logic is right, but I need to look again. I was confused
by the comment changes of the patch.
Rich
> On Mon, Jul 22, 2019 at 8:37 PM James Y Knight <jyknight@...gle.com> wrote:
> >
> > Previously, when given a trailing path component with no
> > metacharacters, glob would call stat to check if the provided filename
> > existed, which would fail on a broken symlink. When expanding a
> > pattern however, glob would trust the list of files returned by
> > readdir, and thus would return broken symlinks.
> >
> > Now, be consistent and allow broken symlinks in both cases, by using
> > lstat to determine file existence.
> >
> > If GLOB_MARK is specified, stat must still be used to determine
> > whether a given name refers to a directory or file. But if that fails,
> > a symlink is simply considered to be a file for marking purposes.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
