Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA2zVHqpF3oHQL51vRQm5B1uK0oTc6qoSCkZxyZfV00BLCu7ng@mail.gmail.com>
Date: Mon, 22 Jul 2019 23:53:33 -0400
From: James Y Knight <jyknight@...gle.com>
To: musl@...ts.openwall.com
Subject: error.h implementation

While these glibc-introduced functions are, IMO, ugly and not really a
worthwhile addition to a libc interface, they do get used. So, in the
interests of compatibility with existing code, here's an
implementation...they're standalone, and pretty trivial, so it seems
reasonable to include, despite it being unfortunate that they exist at
all.

The added test case here passes with both musl and glibc.

A question: is the weak_alias stuff required in this case? I'm not
100% clear as to when that's required, and when it's not, but I think
perhaps it's not actually needed here, because nothing else in the
libc refers to these nonstandard symbols, and the file defines no
standard symbols?

Download attachment "0001-Add-support-for-the-glibc-specific-error.h-header.patch" of type "application/octet-stream" (3685 bytes)

Download attachment "0001-Add-tests-for-error.h-functions.patch" of type "application/octet-stream" (2341 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.