[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <770e0f26-83d0-de0d-a48d-818c3aaccbbe@sholland.org>
Date: Sat, 29 Jun 2019 18:05:31 -0500
From: Samuel Holland <samuel@...lland.org>
To: musl@...ts.openwall.com, Rich Felker <dalias@...c.org>
Subject: Re: [PATCH 0/2] Resolve compiler warnings in master
On 6/29/19 4:46 PM, Rich Felker wrote:
> On Sat, Jun 29, 2019 at 04:22:42PM -0500, Samuel Holland wrote:
>> These two patches resolve some compiler warnings about mismatched
>> attributes and restrict violations. There's another warning, related
>> to duplicate definitions of TIOCSER_TEMT on some arches; I'm not sure
>> which header needs to be changed. It results in:
>>
>> ../include/sys/ioctl.h:47: warning: "TIOCSER_TEMT" redefined
>>
>> The definitions are:
>>
>> arch/mips/bits/termios.h:#define TIOCSER_TEMT 0x01
>> arch/mips64/bits/termios.h:#define TIOCSER_TEMT 0x01
>> arch/mipsn32/bits/termios.h:#define TIOCSER_TEMT 0x01
>> arch/powerpc/bits/termios.h:#define TIOCSER_TEMT 0x01
>> arch/powerpc64/bits/termios.h:#define TIOCSER_TEMT 0x01
>> include/sys/ioctl.h:#define TIOCSER_TEMT 1
>
> I don't see how this is happening with a consistent tree. Commit
> 3517d74a5e04a377192d1f4882ad6c8dc22ce69a removed it from the bits
> headers.
That commit removed it from bits/ioctl.h. The definition is still in
bits/termios.h, where it was changed in 9eda4dc69c33852c97c6f69176bf45ffc80b522f
to match the old value in bits/ioctl.h. So maybe sys/ioctl.h needs to be changed
from 1 to 0x01?
Cheers,
Samuel
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
