[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190512142408.2to3ealai3cbtbf5@gmail.com>
Date: Sun, 12 May 2019 22:24:08 +0800
From: Fangrui Song <i@...kray.me>
To: Rich Felker <dalias@...c.org>
Cc: musl@...ts.openwall.com
Subject: Re: [PATCH] remove unused variables from dynlink.c
On 2019-05-12, Rich Felker wrote:
>On Sun, May 12, 2019 at 09:51:07AM -0400, Rich Felker wrote:
>> On Sun, May 12, 2019 at 09:50:50AM +0800, Fangrui Song wrote:
>> >
>> > ---
>> > ldso/dynlink.c | 1 -
>> > 1 file changed, 1 deletion(-)
>> >
>> > diff --git a/ldso/dynlink.c b/ldso/dynlink.c
>> > index 42a5470d..ad0cdba2 100644
>> > --- a/ldso/dynlink.c
>> > +++ b/ldso/dynlink.c
>> > @@ -86,7 +86,6 @@ struct dso {
>> > size_t relro_start, relro_end;
>> > uintptr_t *new_dtv;
>> > unsigned char *new_tls;
>> > - volatile int new_dtv_idx, new_tls_idx;
>> > struct td_index *td_index;
>> > struct dso *fini_next;
>> > char *shortname;
>> > --
>> > 2.21.0
>>
>> Looks ok. Your mail client seems to have corrupted the patch though;
>> git am is rejecting it for some reason. I'll apply it manually. In the
>> future if you can't get your mail client to send patches inline
>> without breaking the formatting, attachments are fine/preferred.
>
>For future reference, I found what happened: it seems to have removed
>the leading space at the beginning of the context lines (lines with no
>+ or -).
>
>Rich
Weird. I created the patch with `git format-patch --stdout -1 HEAD`,
sent an email with neomutt to myself, then resent (<esc>e) it to the
musl mailing list. Just now I checked my copy of the sent mail has the
desired leading \t.
I'll just attach a text/x-diff file next time.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
