[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANmYxDuccuwi4T0Fz4WtSOERJT3p9uouoqtwf0R44dfmD_2tgw@mail.gmail.com>
Date: Thu, 14 Feb 2019 16:24:03 -0800
From: Nick Bray <ncbray@...gle.com>
To: musl@...ts.openwall.com
Subject: [PATCH] eliminate strict parentheses warnings for byteswaps
Patch is attached.
The change was motivated by including Musl's headers from a project
with -Werror -Wall enabled. I believe Fucshia ran into this, too. I
couldn't think of a good regression test, in part because warnings are
somewhat compiler specific. One possible approach would be to enable
-Werror -Wall in the main build, but that runs into issues of which
compilers are supported and what the core developers prefer. Another
approach would be to only lint the header files - generate a dummy .c
file that includes all the header files and compile it with -Werror.
This is complicated by the "redirection" header files that warn you
should use the canonical version. Which header files should be
checked? So for the moment I punted on regression testing. I mention
this line of thinking in case anyone has some perspective.
View attachment "0001-eliminate-strict-parentheses-warnings-for-byteswaps.patch" of type "text/x-patch" (1673 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
