[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190211233036.GG23599@brightrain.aerifal.cx>
Date: Mon, 11 Feb 2019 18:30:36 -0500
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: Re: [musl-cross-make] [PATCH] litecross: Pass
--enable-deterministic-archives to binutils, not gcc
On Sun, Feb 10, 2019 at 11:27:21AM -0800, Michael Forney wrote:
> On 2018-11-05, Michael Forney <mforney@...rney.org> wrote:
> > When the gcc and binutils build trees were separated in defdbb4505,
> > --enable-deterministic-archives was accidentally left in FULL_GCC_CONFIG.
> > This had the effect of reverting commit e83fe4b8ce, breaking
> > reproducible builds (unless it was specified explicitly in config.mak).
> > ---
> > litecross/Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/litecross/Makefile b/litecross/Makefile
> > index 2f78157..4ecfa93 100644
> > --- a/litecross/Makefile
> > +++ b/litecross/Makefile
> > @@ -61,7 +61,8 @@ FULL_BINUTILS_CONFIG = \
> > --disable-werror \
> > --target=$(TARGET) --prefix= \
> > --libdir=/lib --disable-multilib \
> > - --with-sysroot=$(SYSROOT)
> > + --with-sysroot=$(SYSROOT) \
> > + --enable-deterministic-archives
> >
> > FULL_GCC_CONFIG = --enable-languages=c,c++ \
> > $(GCC_CONFIG_FOR_TARGET) \
> > @@ -74,7 +75,6 @@ FULL_GCC_CONFIG = --enable-languages=c,c++ \
> > --disable-libmudflap --disable-libsanitizer \
> > --disable-gnu-indirect-function \
> > --disable-libmpx \
> > - --enable-deterministic-archives \
> > --enable-libstdcxx-time
> >
> > FULL_MUSL_CONFIG = $(MUSL_CONFIG) \
> > --
> > 2.19.1
>
> Ping. I think this patch should be pretty uncontroversial. It is a
> simple fix for a regression introduced in defdbb4505.
>
> Would you prefer a github pull request instead?
Sorry, it was just an oversight. Applying. Thanks!
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
