[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0ab4cefc-b617-2a1d-aa6f-5aed2257a0f7@adelielinux.org>
Date: Sun, 20 Jan 2019 15:12:59 -0600
From: "A. Wilcox" <awilfox@...lielinux.org>
To: musl@...ts.openwall.com
Subject: Re: <shadow.h> function: fgetspent_r
On 01/20/19 09:41, Markus Wichmann wrote:
> Hi all,
>
> so, I wrote a version of fgetspent_r() now. I based it on fgetspent().
> For style, I adopted the Linux style -- might need to refactor that.
> Returning EILSEQ on format error is a hack, but I found no better code.
> As I said, glibc loops on error, but we do that for no other src/passwd
> function, so we should either not start now or add that feature to every
> other function.
>
> One thing I noticed: If AccountService requires this interfaces, is it
> possible that it doesn't support TCB shadow files?
>
> Ciao,
> Markus
It doesn't support TCB shadow files.
> +int fgetspent_r(FILE *f, struct spwd* sp, char *line, size_t size,
struct spwd **spret)
Tiny style nit: I think the * is meant to be kept with 'sp', not 'spwd',
in the second argument.
Thank you so much for this! I will test this patch out ASAP and report
how well it works.
Best,
--arw
--
A. Wilcox (awilfox)
Project Lead, Adélie Linux
https://www.adelielinux.org
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
