Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181121150903.GN21289@port70.net>
Date: Wed, 21 Nov 2018 16:09:04 +0100
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Cc: Ondrej Jirman <megous@...ous.com>
Subject: Re: [RFC PATCH] Fix __libc_start_main prototype in [r]crt1.c
 to match the caller

* megous@...ous.com <megous@...ous.com> [2018-11-21 15:51:50 +0100]:
> From: Ondrej Jirman <megous@...ous.com>
> 
> __libc_start_main function is not using the last three arguments.
> GCC in LTO mode complains about mismatch.

fix it in the other way then.

> -	__libc_start_main(main, argc, argv, _init, _fini, 0);
> +	__libc_start_main(main, argc, argv);

you just completely broke everything there didnt you?

how will the _init/_fini code of executables with
DT_INIT, DT_FINI dynamic tags run?

i think gcc still havent fixed weak object symbol alias
bugs with lto so e.g. you will get incorrect environ if
you lto link the libc.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69271

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.