Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180920084909.GA10209@port70.net>
Date: Thu, 20 Sep 2018 10:49:09 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] new tsearch implementation

* Rich Felker <dalias@...c.org> [2018-09-19 21:24:11 -0400]:
> On Wed, Sep 19, 2018 at 02:02:47AM +0200, Szabolcs Nagy wrote:
> > -The BSD PRNG implementation (src/prng/random.c) and XSI search API
> > -(src/search/*.c) functions are Copyright © 2011 Szabolcs Nagy and
> > -licensed under following terms: "Permission to use, copy, modify,
> > -and/or distribute this code for any purpose with or without fee is
> > -hereby granted. There is no warranty."
> > -
> >  The x86_64 port was written by Nicholas J. Kain and is licensed under
> >  the standard MIT terms.
> 
> This part fails to apply because your MUA reencoded the attachment to
> latin1. Not a big problem (piping thru iconv -f latin1 fixed it) but
> it's something you might want to be aware of. Ideally mutt should have
> a way to tell it not to reencode attachments, ever, but this generally
> works to avoid the problem assuming your data is UTF-8:
> 
> set send_charset="us-ascii:utf-8"
...
> > +		//  / \             / \
> > +		// A   y    -->    x   D
> > +		//    / \         / \
> > +		//   z   D       A   z
> 
> These comments trigger -Wcomment since they have lines ending in \ in
> a //-form comment. I think the easiest solution is converting them to
> the style of /**/ comment used elsewhere, with *'s lined up in each
> line.
> 

oops, yes, that's a reasonable fix.
i can send an updated patch later if you need it.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.