[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180824220523.GF4418@port70.net>
Date: Sat, 25 Aug 2018 00:05:23 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] fix build failure on arm because of missing clz
instruction
* Andre McCurdy <armccurdy@...il.com> [2018-08-24 14:58:04 -0700]:
> On Fri, Aug 24, 2018 at 12:30 PM, Szabolcs Nagy <nsz@...t70.net> wrote:
> > another arm patch, clz usage (in fma) was broken with -mthumb -march=armv5t.
>
> That conditional was originally written under the assumption that musl
> doesn't support thumb1 (so -mthumb -march=armv5t is not a supported
> configuration).
>
> Was that assumption wrong?
the asm code in musl does not support thumb1,
but you can compile everything else with thumb1
(the compiler does not pass -mthumb to the assembler
by default so all asm code will be in arm mode)
so with the changed condition the build succeeds
with -mthumb -march=armv5t, but the resulting libc
will not be competely thumb code, i think that's
an improvement.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
