[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJ86T=UtxCYVgnWG3apZc=EOz1iPn8X1vEqgV1n+0BGyL96_EQ@mail.gmail.com>
Date: Tue, 27 Feb 2018 16:37:15 -0800
From: Andre McCurdy <armccurdy@...il.com>
To: musl@...ts.openwall.com
Subject: Re: clz instruction is unavailable for Thumb1
On Tue, Feb 27, 2018 at 4:03 PM, Zhao, Weiming <weimingz@...eaurora.org> wrote:
> In arch/arm/atomic_arch.h, it checks for __ARM_ARCH >= 5, which is not
> sufficient.
>
> for example, for armv6-m, it only support Thumb1, which doesn't include clz.
>
> Suggest to check if it's building for thumb1:
Musl does not currently support Thumb 1.
> diff --git a/arch/arm/atomic_arch.h b/arch/arm/atomic_arch.h
> index c5c56f8..e3cb66a 100644
> --- a/arch/arm/atomic_arch.h
> +++ b/arch/arm/atomic_arch.h
> @@ -82,7 +82,7 @@ static inline void a_crash()
> : : : "memory");
> }
>
> -#if __ARM_ARCH >= 5
> +#if __ARM_ARCH >= 5 && !(defined(__thumb__) && !defined(__thumb2))
>
>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
> The Linux Foundation
>
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
