musl - [PATCH] Use LDFLAGS when testing linker flags

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0502MB3885C5129C26CEF375ECF862E7330@VI1PR0502MB3885.eurprd05.prod.outlook.com>
Date: Thu, 7 Dec 2017 16:03:03 +0000
From: Nicholas Wilson <nicholas.wilson@...lvnc.com>
To: "musl@...ts.openwall.com" <musl@...ts.openwall.com>
Subject: [PATCH] Use LDFLAGS when testing linker flags

Hi,

This is another patch for the WebAssembly build.

In Wasm, we currently need to pass some extra flags to the linker, and LDFLAGS would seem to be a good way to do this.

The patch below tests the linker by passing LDFLAGS on the link line. This ought to be a safe change to make?

Thanks,
Nick

=======
commit a951daab68b4b6ee6f46278f02df279188559b89
Author: Nicholas Wilson <nicholas.wilson@...lvnc.com>
Date:   Thu Dec 7 15:42:58 2017 +0000

    [Wasm] Use LDFLAGS when testing linker

diff --git a/configure b/configure
index f320660d..519d31fa 100755
--- a/configure
+++ b/configure
@@ -98,7 +98,7 @@ fi
 tryldflag () {
 printf "checking whether linker accepts %s... " "$2"
 echo "typedef int x;" > "$tmpc"
-if $CC $LDFLAGS_TRY -nostdlib -shared "$2" -o /dev/null "$tmpc" >/dev/null 2>&1 ; then
+if $CC $LDFLAGS $LDFLAGS_TRY -nostdlib -shared "$2" -o /dev/null "$tmpc" >/dev/null 2>&1 ; then
 printf "yes\n"
 eval "$1=\"\${$1} \$2\""
 eval "$1=\${$1# }"

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.