Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9f1a274a-1529-a1c3-0de3-d3bab1f7e8fe@nbd.name>
Date: Mon, 16 Oct 2017 16:09:16 +0200
From: Felix Fietkau <nbd@....name>
To: Koen Vandeputte <koen.vandeputte@...ntric.com>,
 Syrone Wong <wong.syrone@...il.com>, musl@...ts.openwall.com
Subject: Re: [LEDE-DEV] [PATCH 1/2] musl: update to 1.1.16+ git HEAD
 2017-09-28

On 2017-10-16 16:03, Szabolcs Nagy wrote:
> * Koen Vandeputte <koen.vandeputte@...ntric.com> [2017-10-16 10:31:11 +0200]:
>> I've proposed to update the musl libc within the LEDE project and received
>> some feedback from Syrone Wong (in cc).
>> 
>> According to him, your upstream commit in musl [1] seems to break something.
>> (see below)
>> 
>> - Can you confirm this?
>> - Would you have any clue what the reason could be?
> ...
>> [1]
>> "powerpc{64}: fix MAP_NORESERVE and MAP_LOCKED in mman.h"
>> http://git.musl-libc.org/cgit/musl/commit/?id=c10bc61508dc52b8315084e628f36a6c3c2dabb1
>> 
> 
> these are rarely used mmap flags, i think my patch is correct.
> 
> the old value in musl was wrong on powerpc (i think the old
> value did not collide with other map flags so the kernel would
> report EINVAL if these flags were ever used).
I don't think this commit is the cause at all. The bug reporter was
using an ARM device and this commit only touches powerpc header files.
Probably the issue is somewhere between the version that LEDE uses now
and the version with this commit id.

- Felix

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.