Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20170914205321.18733-1-awilfox@adelielinux.org>
Date: Thu, 14 Sep 2017 15:53:21 -0500
From: "A. Wilcox" <awilfox@...lielinux.org>
To: musl@...ts.openwall.com
Cc: "A. Wilcox" <AWilcox@...cox-Tech.com>
Subject: [PATCH] __lookup_serv: return correct error code

From: "A. Wilcox" <AWilcox@...cox-Tech.com>

If AI_NUMERICSERV is specified and a numeric service was not provided,
POSIX mandates getaddrinfo return EAI_NONAME.  EAI_SERVICE is only for
services that cannot be used on the specified socket type.
---
 src/network/lookup_serv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/network/lookup_serv.c b/src/network/lookup_serv.c
index 66ebaea..403b12a 100644
--- a/src/network/lookup_serv.c
+++ b/src/network/lookup_serv.c
@@ -64,7 +64,7 @@ int __lookup_serv(struct service buf[static MAXSERVS], const char *name, int pro
 		return cnt;
 	}
 
-	if (flags & AI_NUMERICSERV) return EAI_SERVICE;
+	if (flags & AI_NUMERICSERV) return EAI_NONAME;
 
 	size_t l = strlen(name);
 
-- 
2.10.0

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.