[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170705151555.GY1627@brightrain.aerifal.cx>
Date: Wed, 5 Jul 2017 11:15:55 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] Change ENDIAN_SUFFIX definition from 'le' to 'el'
On Wed, Jul 05, 2017 at 05:07:17PM +0200, liu.ming50@...il.com wrote:
> From: Ming Liu <peter.x.liu@...ernal.atlascopco.com>
>
> To be consistent with the same macros in other ARCHs.
>
> Signed-off-by: Ming Liu <peter.x.liu@...ernal.atlascopco.com>
> ---
> arch/powerpc64/reloc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc64/reloc.h b/arch/powerpc64/reloc.h
> index faf70ac..9a4744a 100644
> --- a/arch/powerpc64/reloc.h
> +++ b/arch/powerpc64/reloc.h
> @@ -1,7 +1,7 @@
> #include <endian.h>
>
> #if __BYTE_ORDER == __LITTLE_ENDIAN
> -#define ENDIAN_SUFFIX "le"
> +#define ENDIAN_SUFFIX "el"
> #else
> #define ENDIAN_SUFFIX ""
> #endif
> --
> 2.7.4
This is an ABI-breaking change and thus not appropriate. Anyway, the
intent is not to be consistent with other archs but too be consistent
with existing naming practice for the particular arch, where
powerpc64le, not powerpc64el, is what's used.
BTW if it were being changed, the subarch logic in configure would
also need to be changed to match.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
