Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170704222842.GV1627@brightrain.aerifal.cx>
Date: Tue, 4 Jul 2017 18:28:42 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] missing volatile in __get_locale

On Wed, Jul 05, 2017 at 01:24:23AM +0300, Alexander Monakov wrote:
> On Tue, 4 Jul 2017, Rich Felker wrote:
> 
> > Thanks, applying.
> 
> Can you please document the rationale for using bare ints instead of 
> an explicit struct for internal locks?

I don't think there was/is any good one, it was just the choice that
was made at the time. At one point there might have been places it
avoided need for including a header to define the type, or where being
explicit about the storage needed for the lock mattered (think stdio
FILE layout, but it uses its own lock anyway), but I think it was
mostly unjustified. I wouldn't be opposed to changing it.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.