Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.20.13.1706152015390.13954@monopod.intra.ispras.ru>
Date: Thu, 15 Jun 2017 20:19:29 +0300 (MSK)
From: Alexander Monakov <amonakov@...ras.ru>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] Handle localtime errors in ctime

On Thu, 15 Jun 2017, Rich Felker wrote:
> > Um, the previous time an opposite direction was taken:
> > http://www.openwall.com/lists/musl/2014/09/05/17
> 
> I found this in POSIX while reviewing the new patch:
> 
> [CX] [Option Start] Upon successful completion, ctime_r() shall return
> a pointer to the string pointed to by buf. When an error is
> encountered, a null pointer shall be returned. [Option End]
> 
> So while ISO C may not have anything to say about it (i.e. it's UB in
> plain C), POSIX does seem to require handling the error. I forgot we'd
> looked at this before but it seems we missed what POSIX had to say.

... even though the quoted POSIX spec specifically mentions ctime_r, not ctime?
(musl implementation of ctime_r does appear to miss that, though)

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.