[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170417173546.GB17319@brightrain.aerifal.cx>
Date: Mon, 17 Apr 2017 13:35:46 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: superfluous space char in marco
On Mon, Apr 17, 2017 at 07:29:19PM +0200, Szabolcs Nagy wrote:
> * Rich Felker <dalias@...c.org> [2017-04-17 13:02:08 -0400]:
> > On Mon, Apr 17, 2017 at 06:28:58PM +0300, Alexander Monakov wrote:
> > > On Mon, 17 Apr 2017, Rich Felker wrote:
> > > > This is odd and looks like a gcc bug. Preprocessor macros definitions
> > > > are sequences of PP tokens, not literal code strings, meaning that
> > > > whitespace is irrelevant as long as the resulting sequence of PP
> > > > tokens remains the same; it's a matching definition not a
> > > > redefinition.
> > >
> > > No, according to C11 6.10.3 p1 presence of whitespace is significant (its
> > > contents are not), and 6.10.3.5 example 6 corroborates that. GCC, Clang,
> > > ICC and MSVC on Godbolt all agree with that.
> >
> > Thanks for clarifying! I had forgotten this detail. It probably makes
> > sense to change it, then.
>
> linux uapi header has whitespace befor IFF_MASTER
> if we match the definition with something i think
> it should be the linux header not iproute2
Yes, the official Linux one, not iproute2's fork, is what we should
match, if anything.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
