Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAEaqfoZUb5XOstw4A+NNScHbbYfpqDQAbaSPEL+n_P-QDCqcfg@mail.gmail.com>
Date: Sun, 16 Apr 2017 15:58:11 +0800
From: Syrone Wong <wong.syrone@...il.com>
To: musl@...ts.openwall.com
Subject: superfluous space char in marco

For include/net/if.h, we define it as

#define IFF_VOLATILE (IFF_LOOPBACK|IFF_POINTOPOINT|IFF_BROADCAST| \
        IFF_ECHO|IFF_MASTER|IFF_SLAVE|IFF_RUNNING|IFF_LOWER_UP|IFF_DORMANT)

while iproute2 4.10.0 define it as

#define IFF_VOLATILE (IFF_LOOPBACK|IFF_POINTOPOINT|IFF_BROADCAST|IFF_ECHO|\
IFF_MASTER|IFF_SLAVE|IFF_RUNNING|IFF_LOWER_UP|IFF_DORMANT)

in include/linux/if.h. The only difference is the space char after
IFF_BROADCAST.

This causes the redefinition of IFF_VOLATILE.

Warning when compiling iproute2 4.10.0:

In file included from ../include/linux/if_tunnel.h:5:0,
                 from iptunnel.c:24:
../include/linux/if.h:130:0: warning: "IFF_VOLATILE" redefined
 #define IFF_VOLATILE (IFF_LOOPBACK|IFF_POINTOPOINT|IFF_BROADCAST|IFF_ECHO|\

In file included from iptunnel.c:21:0:
/home/wong/github/lede-1/staging_dir/toolchain-arm_cortex-a9+vfpv3_gcc-6.3.0_musl_eabi/include/net/if.h:48:0:
note: this is the location of the previous definition
 #define IFF_VOLATILE (IFF_LOOPBACK|IFF_POINTOPOINT|IFF_BROADCAST| \


Best Regards,
Syrone Wong

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.