[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170129133946.GT17692@port70.net>
Date: Sun, 29 Jan 2017 14:39:47 +0100
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: Re: a bug in bindtextdomain() and strip '.UTF-8'
* He X <xw897002528@...il.com> [2017-01-29 12:52:56 +0800]:
> 1. no memset after malloc, caused chromium crash:
> http://www.openwall.com/lists/musl/2017/01/28/1
> --- musl-1.1.16/src/locale/dcngettext.c 2017-01-29 04:42:49.002221317 +0000
> +++ musl-1.1.16/src/locale/dcngettext.c 2017-01-29 04:42:49.002221317 +0000
> @@ -180,6 +180,7 @@
> __munmap((void *)map, map_size);
> goto notrans;
> }
> + memset(p, 0, sizeof *p + namelen + 1);
> p->map = map;
> p->map_size = map_size;
> memcpy(p->name, name, namelen+1);
if you want to zero the entire allocation, then use calloc.
but i think initializing plural_rule is enough.
> 2. musl uses generic config of libstdc++, which blocked the support of
> locale, patch is there:
> https://github.com/xhebox/noname-linux/issues/2#issuecomment-275704150
this breaks the abi of libstdc++ because the definition of
a type in the public api is changed.
so existing c++ binaries break if the toolchain is patched.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
