[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20161128193100.GX1555@brightrain.aerifal.cx>
Date: Mon, 28 Nov 2016 14:31:00 -0500
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] s390: replace absolute branch with relative branch
On Sun, Nov 27, 2016 at 12:18:10PM -0600, Bobby Bingham wrote:
> ---
> src/signal/s390x/sigsetjmp.s | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/signal/s390x/sigsetjmp.s b/src/signal/s390x/sigsetjmp.s
> index 72dfc25..41b1bd9 100644
> --- a/src/signal/s390x/sigsetjmp.s
> +++ b/src/signal/s390x/sigsetjmp.s
> @@ -6,7 +6,7 @@
> sigsetjmp:
> __sigsetjmp:
> ltgr %r3, %r3
> - bz ___setjmp
> + jz ___setjmp
>
> stg %r14, 18*8(%r2)
> stg %r6, 20*8(%r2)
The patch is probably okay but it needs a meaningful commit message.
The one you supplied merely restates the content of the diff in
English. What bug (crashing sigsetjmp, I think) is this fixing and why
is this change a/the right fix?
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
