Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20161107170323.GE1555@brightrain.aerifal.cx>
Date: Mon, 7 Nov 2016 12:03:23 -0500
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] fix ldso reserved library name handling

On Tue, Nov 01, 2016 at 02:49:09AM +0100, Szabolcs Nagy wrote:
> If a DT_NEEDED entry was the prefix of a reserved library name
> (up to the first dot) then it was incorrectly treated as a libc
> reserved name.
> 
> e.g. libp.so dependency was not loaded as it matched libpthread
> reserved name.
> ---
> 
> this is not the smallest possible patch (most of the diff is
> indentation change), but i found the code cleaner without
> the z and l-3 computation.
> 
>  ldso/dynlink.c | 38 +++++++++++++++++++-------------------
>  1 file changed, 19 insertions(+), 19 deletions(-)

The existing code was obviously wrong and this seems to work with
simple testing (dlopen of reserved names still yields self pointer,
dlopen of nonexistent prefixes fails) so I'm committing it. Thanks.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.