Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20161101014456.GE5749@port70.net>
Date: Tue, 1 Nov 2016 02:44:56 +0100
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: [PATCH] fix accidental global static pointer in ldso

this was harmless as load_library is not called concurrently,
but it used one word of bss.
---
 ldso/dynlink.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ldso/dynlink.c b/ldso/dynlink.c
index e458f38..d11776d 100644
--- a/ldso/dynlink.c
+++ b/ldso/dynlink.c
@@ -905,8 +905,9 @@ static struct dso *load_library(const char *name, struct dso *needed_by)
 
 	/* Catch and block attempts to reload the implementation itself */
 	if (name[0]=='l' && name[1]=='i' && name[2]=='b') {
-		static const char *rp, reserved[] =
+		static const char reserved[] =
 			"c\0pthread\0rt\0m\0dl\0util\0xnet\0";
+		const char *rp;
 		char *z = strchr(name, '.');
 		if (z) {
 			size_t l = z-name;
-- 
2.10.1

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.