[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.20.13.1610271405590.31266@monopod.intra.ispras.ru>
Date: Thu, 27 Oct 2016 14:12:08 +0300 (MSK)
From: Alexander Monakov <amonakov@...ras.ru>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] configure: fix ctrl+C
On Mon, 24 Oct 2016, Laine Gholson wrote:
> the trap in the configure script doesn't exit like it should, fix that, and
> while I am at it, use rm -f to fix spurious errors from rm.
Did you observe such an error in practice? If so, I'm curious what it was, I
don't see how it can arise because "$tmpc" is created before the trap is
installed, and is not removed other than by the trap.
> --- a/configure
> +++ b/configure
> @@ -214,7 +214,7 @@ tmpc="./conf$$-$PPID-$i.c"
> test "$i" -gt 50 && fail "$0: cannot create temporary file $tmpc"
> done
> set +C
> -trap 'rm "$tmpc"' EXIT INT QUIT TERM HUP
> +trap 'rm -f "$tmpc"; exit 1' EXIT INT QUIT TERM HUP
This will cause configure to exit with status 1 even on normal termination,
though.
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
