[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20161021173427.GW19318@brightrain.aerifal.cx>
Date: Fri, 21 Oct 2016 13:34:27 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: musl's strptime does not support POSIX %U/%W
On Fri, Oct 21, 2016 at 12:18:22PM -0400, Rich Felker wrote:
> On Fri, Oct 21, 2016 at 11:00:35AM +0200, Raphael 'kena' Poss wrote:
> > Hi all,
> >
> > we at CockroachDB would like to integrate strptime, but some of our
> > users on Alpine Linux discovered that musl's strptime doesn't live up to
> > expectations:
> >
> > conv_test.go:58: strptime("2018 10 4", "%Y %W %w"): got
> > "2017-12-31T00:00:00Z", expected "2018-03-08T00:00:00Z"
> > conv_test.go:58: strptime("2018 10 4", "%Y %U %w"): got
> > "2017-12-31T00:00:00Z", expected "2018-03-15T00:00:00Z"
> >
> > Indeed there's a FIXME in there:
> > https://git.musl-libc.org/cgit/musl/tree/src/time/strptime.c#n123
> >
> > We've filed this internally as
> > https://github.com/cockroachdb/cockroach/issues/10130
> >
> > As of this day this is the only known limitation that prevents
> > compatibility of CockroachDB with musl. If you have any suggestions /
> > input we'd be glad to receive them!
>
> Indeed, somehow I thought this FIXME had been fixed a long time ago,
> but it seems it hasn't. I'll see if we can get it added soon.
Looking at this in more detail, I see why it wasn't done before:
there's no clear spec for what output these should produce. struct tm
does not contain a week-number field, so the result would have to be
encoded in other fields -- but which ones? tm_yday? strptime is not
specified to produce a full, consistent struct tm for all inputs,
because many formats may be incomplete and other combinations of
format and input may yield contradictory information.
I'd be really interested in seeing some analysis of this situation by
someone who's studied it and has a viable proposal other than just
"reverse engineer glibc and do whatever it does".
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
