[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAFhhQJTNHWzQG6qvW9OcFQN7L1w=v=sE2=Upv1fN9KF=GYP1Tw@mail.gmail.com>
Date: Thu, 13 Oct 2016 13:43:28 -0400
From: Daniel Sabogal <dsabogalcc@...il.com>
To: musl@...ts.openwall.com
Subject: Re: getopt_long_only
On Thu, Oct 13, 2016 at 10:42 AM, Sidney Manning <sidneym@...eaurora.org> wrote:
> I may have found an issue with this API. When a double hyphen is
> encountered the API is supposed to return a -1 but I'm seeing a '?'.
>
> My reference is from the Solaris docs which say: "The special option "--"
> can be used to delimit the end of the options; when it is encountered, -1 is
> returned and "--" is skipped. I attached a test case to show the problem.
>
> I made the following change it will cause the code to punt to getopt when
> just a "--" is found:
> argv[optind][0] == '-'
> argv[optind][1] == '-'
> argv[optind][2] == NULL
>
> diff --git a/src/misc/getopt_long.c b/src/misc/getopt_long.c
> index 480c001..9764f56 100644
> --- a/src/misc/getopt_long.c
> +++ b/src/misc/getopt_long.c
> @@ -53,7 +53,7 @@ static int __getopt_long_core(int argc, char *const *argv,
> con
> {
> optarg = 0;
> if (longopts && argv[optind][0] == '-' &&
> - ((longonly && argv[optind][1]) ||
> + ((longonly && argv[optind][1]) &&
> (argv[optind][1] == '-' && argv[optind][2])))
> {
> int colon =
> optstring[optstring[0]=='+'||optstring[0]=='-']==':'
This will break getopt_long() since the entire condition won't hold
whenever !longonly.
I think just changing the longonly case to the following is sufficient.
(longonly && argv[optind][1] && argv[optind][1] != '-')
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
