[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.20.1610051243530.35196@virtualbox>
Date: Wed, 5 Oct 2016 12:49:48 +0200 (CEST)
From: Johannes Schindelin <Johannes.Schindelin@....de>
To: writeonce@...ipix.org
cc: musl@...ts.openwall.com, git@...r.kernel.org, Jeff King <peff@...f.net>
Subject: RE: Re: Regression: git no longer works with musl libc's
regex impl
Hi writeonce,
On Tue, 4 Oct 2016, writeonce@...ipix.org wrote:
> < On Tue, 4 Oct 2016, Rich Felker wrote:
> <
> < > On Tue, Oct 04, 2016 at 11:27:22AM -0400, Jeff King wrote:
> < > > On Tue, Oct 04, 2016 at 11:08:48AM -0400, Rich Felker wrote:
> < > >
> < > > > 1. is nonzero mod page size, it just works; the remainder of the
> < > > > last page reads as zero bytes when mmapped.
> < > >
> < > > Is that a portable assumption?
> < >
> < > Yes.
> <
> < No, it is not. You quote POSIX, but the matter of the fact is that we
> < use a subset of POSIX in order to be able to keep things running on
> < Windows.
>
> As far as I can tell (and as the attached program may help demonstrate),
> the above assumption has been valid on all versions of Windows since at
> least Windows 2000.
And since W2K is already past its end of life, it would be safe for
practical considerations.
However, I have to add two comments to that:
- it is *not* guaranteed. The behavior is undefined, even if you see
consistent behavior so far. Future Windows versions might break that
assumption freely, though.
- some implementations of the REG_STARTEND feature have the nice property
that they can read past NUL characters. Granted, not all of them do
(AFAIU one example is FreeBSD itself, the first platform to sport
REG_STARTEND), but we at least reap the benefit whenever using a regex
that *can* read past NUL characters.
> In this context, one thing to remember is that the page-size for the mod
> operation is 4096, whereas the POSIX page-size (for the purpose of mmap
> and mremap) is 65536.
Indeed. A colleague of mine spotted the segfault when diffing a file that
was *exactly* 4,096 bytes.
> Note also that in the case of file-backed mapped sections, using
> kernel32.dll or msvcrt.dll or cygwin/newlib or midipix/musl is of little
> significance, specifically since all invoke ZwCreateSection and
> ZwMapViewOfSection under the hood.
Right. It's all backed by the very same kernel functions.
Ciao,
Johannes
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
