Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160913204149.GX15995@brightrain.aerifal.cx>
Date: Tue, 13 Sep 2016 16:41:50 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: incompatibility between libtheora/mmx and musl ?

On Tue, Sep 13, 2016 at 09:20:06PM +0200, Markus Wichmann wrote:
> On Tue, Sep 13, 2016 at 08:06:49PM +0200, u-uy74@...ey.se wrote:
> >  https://trac.xiph.org/ticket/2287
> 
> Alright, I had a look at it.
> 
> 1. The free() in the loader: That would be reclaim_gaps(). valgrind
> really doesn't like it.
> 
> 2. Uninitialized values in calloc: There is only one conditional in
> calloc(), and it depends on the two parameters. Is it possible that
> those are uninitialized?

I think this is also a false positive -- valgrind treats calloc as a
normal consumer of malloc rather than part of the malloc
implementation and thus does not like the conditional zeroing:

	for (z=p; n; n--, z++) if (*z) *z=0;

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.